Fix handling of prerelease-only resolutions #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <[email protected]>
We need `all([any(...) ...])` because of the nested iterators here: we check whether each requirement's specifier allows this candidate, and all specifiers need to allow it.
woodruffw
changed the title
|
Thanks again for reporting this @redbmk! I can confirm that these changes appear to fix the bug for me: $ pip-audit -r <(echo 'sqlalchemy2-stubs') --format=json
No known vulnerabilities found
{"dependencies": [{"name": "sqlalchemy2-stubs", "version": "0.0.2a32", "vulns": []}, {"name": "typing-extensions", "version": "4.4.0", "vulns": []}], "fixes": []}Would you mind also giving them a spin and letting me know if they work for you as well? |
di
approved these changes
Jan 20, 2023
|
This is perfect - works like a charm! Thanks for fixing this so fast! |
No problem, thanks again for helping us debug! I'll get a patch release made to ship this out as well. |
Merged
|
Awesome, thanks! Was just going to ask what your typical release cadence was - I'll keep an eye out for the release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP; just for visibility into where I've inserted debug statements.Fixes #472.
Signed-off-by: William Woodruff [email protected]