Use packaging.version to check version equality

pypa · Nov 1, 2020 · 00f9234 · 00f9234
1 parent 5ee7caf
commit 00f9234
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/news/9083.bugfix.rst b/news/9083.bugfix.rst
@@ -0,0 +1,3 @@
+New resolver: Check version equality with ``packaging.version`` to avoid edge
+cases if a wheel used different version normalization logic in its filename
+and metadata.
diff --git a/src/pip/_internal/resolution/resolvelib/candidates.py b/src/pip/_internal/resolution/resolvelib/candidates.py
@@ -283,9 +283,10 @@ def __init__(
             )
             # Version may not be present for PEP 508 direct URLs
             if version is not None:
-                assert str(version) == wheel.version, (
+                wheel_version = Version(wheel.version)
+                assert version == wheel_version, (
                     "{!r} != {!r} for wheel {}".format(
-                        version, wheel.version, name
+                        version, wheel_version, name
                     )
                 )