-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test_download_use_pep517_propagation: use a different approach
The approach it uses now doesn't work anymore due to 452d7da. The installation of `fake_dep` now succeeds whether or not `setuptools` is installed in the test environment. Use a different approach instead: try to import `pip` in the `setup.py` script. If it succeeds, then we are not running in an isolated environment, and therefore PEP 517 isn't being used. To add this custom logic to `setup.py`, add a new argument to `create_basic_sdist_for_package`. Note that to make this work, I had to switch from f-strings to `str.format`, since the `dedent` has to happen before formatting.
- Loading branch information
Showing
2 changed files
with
33 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters