Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyring support #5948

Closed
zooba opened this issue Oct 27, 2018 · 1 comment · Fixed by #5952
Closed

keyring support #5948

zooba opened this issue Oct 27, 2018 · 1 comment · Fixed by #5952
Labels
auto-locked Outdated issues that have been locked by automation C: download About fetching data from PyPI and other sources type: feature request Request for a new feature type: security Has potential security implications

Comments

@zooba
Copy link
Contributor

zooba commented Oct 27, 2018

What's the problem this feature will solve?
Use keyring to resolve (username and) passwords for a repository.

Describe the solution you'd like
In download.py when a 401 is being handled,

This would enable the use of additional backends to store and resolve passwords for installing from private feeds.

Alternative Solutions
For the current (private) previews of this in some services, we generate a new password and provide it to users to include in a pip.ini file. This change would allow them to simply provide the URL on the command line and install a separate package to generate credentials on the fly.

Additional context
See jaraco/keyring#350 for an addition to keyring that will be used (when available) to also resolve usernames as well as passwords.
@zooba
Copy link
Contributor Author

zooba commented Oct 27, 2018

I plan to work on this at the PyPA sprint.

@zooba zooba mentioned this issue Oct 27, 2018
Open
@cjerdonek cjerdonek added type: enhancement Improvements to functionality C: download About fetching data from PyPI and other sources labels Oct 27, 2018
@zooba zooba mentioned this issue Oct 27, 2018
Merged
@cjerdonek cjerdonek added type: feature request Request for a new feature type: security Has potential security implications and removed type: enhancement Improvements to functionality labels Oct 27, 2018
@pradyunsg pradyunsg mentioned this issue Jan 22, 2019
Closed
zooba added a commit to zooba/pip that referenced this issue May 7, 2019
@zooba
Issue pypa#5948: Enable keyring support
c63ee61 
This requires keyring and any backends to be installed separately.
Once discovered, it will be used to retrieve credentials by index URL
and netloc before prompting. If the user is prompted and the
credentials work, they will (optionally) be saved to keyring against
the netloc of the requested URL.
dstufft added a commit that referenced this issue May 10, 2019
@dstufft
Merge pull request #5952 from zooba/issue-5948
3596ad5 
Fixes #5948 Adds keyring support
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: download About fetching data from PyPI and other sources type: feature request Request for a new feature type: security Has potential security implications
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #5948 Adds keyring support zooba/pip
2 participants
@cjerdonek @zooba