Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the annotations for setup.py #10094

Merged
merged 4 commits into from
Jun 27, 2021
Merged

Conversation

DiddiLeija
Copy link
Member

I have been converting type commentaries into annotations. For now, I'll fix some annotations from setup.py.

I have been converting type commentaries into annotations. For now, I'll fix some annotations from `setup.py`.
This is the news entry for my pull request.
@DiddiLeija
Copy link
Member Author

I don't think this is going to take so long: I'm just changing 2 functions in 1 file.

@DiddiLeija
Copy link
Member Author

All the checks passed. Can somebody review this?

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging directly since I can’t think of a way this could possibly go wrong.

@uranusjr uranusjr merged commit 9c2c52b into pypa:main Jun 27, 2021
@DiddiLeija
Copy link
Member Author

Thank you very much for merging 😄.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants