Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packaging to 21.0 #10144

Merged
merged 1 commit into from
Jul 17, 2021
Merged

Upgrade packaging to 21.0 #10144

merged 1 commit into from
Jul 17, 2021

Conversation

lkollar
Copy link
Contributor

@lkollar lkollar commented Jul 7, 2021

Closes: #10089

@uranusjr uranusjr added skip news Does not need a NEWS file entry (eg: trivial changes) and removed skip news Does not need a NEWS file entry (eg: trivial changes) labels Jul 8, 2021
@uranusjr
Copy link
Member

uranusjr commented Jul 8, 2021

Grr, that news file bot.

@uranusjr uranusjr closed this Jul 8, 2021
@uranusjr uranusjr reopened this Jul 8, 2021
@lkollar
Copy link
Contributor Author

lkollar commented Jul 8, 2021

Looks like Python 3.9 on Windows encountered the same singal-related failure in test_download_http_url__no_directory_traversal and test_prepare_download__log:

signalnum = <Signals.SIGINT: 2>
handler = <bound method InterruptibleMixin.handle_sigint of <pip._internal.cli.progress_bars.DownloadProgressSpinner object at 0x000002BCDC661130>>

    @_wraps(_signal.signal)
    def signal(signalnum, handler):
>       handler = _signal.signal(_enum_to_int(signalnum), _enum_to_int(handler))
E       ValueError: signal only works in main thread of the main interpreter

Doesn't seem to have anything to do with packaging 🤷

@puetzk
Copy link
Contributor

puetzk commented Jul 16, 2021

This also fixes #8649 and #9962. These issues were already closed with "R: wrong project" since the issue was pypa/packaging#396, but taking packaging 21.0 means pip picks that change up and thus "fixes" pip in the end-user sense (pip installs the right wheels again).

@pradyunsg pradyunsg closed this Jul 16, 2021
@pradyunsg pradyunsg reopened this Jul 16, 2021
@pradyunsg
Copy link
Member

Third time's the charm?

@uranusjr uranusjr merged commit 76cd70a into pypa:main Jul 17, 2021
@lkollar lkollar deleted the upgrade-packaging branch July 22, 2021 10:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants