Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the freeze command #10410

Merged
merged 6 commits into from
Sep 22, 2021
Merged

Refactor the freeze command #10410

merged 6 commits into from
Sep 22, 2021

Commits on Sep 21, 2021

  1. Make _get_editable_info always return editable=True for editables 

    At the beginning this function returns if not dist.editable.
So returning editable=False after that does not make sense.
Return an editable with the file system location instead when
there is any issue getting VCS information.
    @sbidoul
    sbidoul committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    a3b1d56 View commit details
    Browse the repository at this point in the history

  2. _dist_is_editable always returns a location

    @sbidoul
    sbidoul committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    ddcf558 View commit details
    Browse the repository at this point in the history

  3. _EditableInfo does not need an editable flag 

    It is always true.
    @sbidoul
    sbidoul committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    283cabf View commit details
    Browse the repository at this point in the history

  4. Remove unused type

    @sbidoul
    sbidoul committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    9c31cad View commit details
    Browse the repository at this point in the history

  5. Remove resolved TODO comment

    @sbidoul
    sbidoul committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    36befd8 View commit details
    Browse the repository at this point in the history

  6. Add news

    @sbidoul
    sbidoul committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    6ac3ffe View commit details
    Browse the repository at this point in the history