Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify graph in get_topological_weights. #10574

Merged
merged 13 commits into from
Nov 20, 2021
Merged

Simplify graph in get_topological_weights. #10574

merged 13 commits into from
Nov 20, 2021

Commits on Oct 12, 2021

  1. Simplify graph in get_topological_weights. 

    Fixes #10557 where the resolver spends too much time calculating the weights.

Also, do not let `get_installation_order` calculate these weights at all when there is nothing left to install.
    @mauritsvanrees
    mauritsvanrees committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    af38392 View commit details
    Browse the repository at this point in the history

  2. fix mypy

    @mauritsvanrees
    mauritsvanrees committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    3983756 View commit details
    Browse the repository at this point in the history

  3. Removed outdated comment and no longer needed code.

    @mauritsvanrees
    mauritsvanrees committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    9a97320 View commit details
    Browse the repository at this point in the history

  4. Fixed another mypy warning, about DiGraph having no attr _forwards. 

    I am not used to mypy and did not have pre-commit installed yet.
    @mauritsvanrees
    mauritsvanrees committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    7e53097 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. get_topological_weights: minor improvements from reviews.

    @mauritsvanrees
    mauritsvanrees committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    a6b930b View commit details
    Browse the repository at this point in the history

  2. get_topological_weights: fixed condition. 

    After minor refactoring, the condition was the wrong way around.
    @mauritsvanrees
    mauritsvanrees committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    11ce17e View commit details
    Browse the repository at this point in the history

  3. get_topological_weights: iterate instead of calling next. 

    'next' gives mypy errors.
    @mauritsvanrees
    mauritsvanrees committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    6145342 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Replace the recursive simplify_graph function with a while loop. 

    This is easier to wrap your head around.
    @mauritsvanrees
    mauritsvanrees committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    b5c0b82 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Update news/10557.bugfix.rst 

    Co-authored-by: Tzu-ping Chung <[email protected]>
    @mauritsvanrees @uranusjr
    mauritsvanrees and uranusjr authored Nov 17, 2021
    Configuration menu
    Copy the full SHA
    9408cad View commit details
    Browse the repository at this point in the history

  2. Fixed typo in news snippet.

    @mauritsvanrees
    mauritsvanrees committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    d07cc8c View commit details
    Browse the repository at this point in the history

  3. Fixed comment that still talked about a copy of the graph.

    @mauritsvanrees
    mauritsvanrees committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    43d9434 View commit details
    Browse the repository at this point in the history

  4. Updated docstring of get_installation_order and get_topological_weights.

    @mauritsvanrees
    mauritsvanrees committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    39ce7b5 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Reflow and fix typo in docstrings

    @uranusjr
    uranusjr authored Nov 18, 2021
    Configuration menu
    Copy the full SHA
    69b71ca View commit details
    Browse the repository at this point in the history