Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritize url credentials over netrc #10998

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Prioritize url credentials over netrc #10998

merged 3 commits into from
Apr 8, 2022

Conversation

q0w
Copy link
Contributor

@q0w q0w commented Mar 29, 2022

Closes #10979.

uranusjr
uranusjr reviewed Apr 7, 2022
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nitpicks, the general logic looks right to me.

news/10979.bugfix.rst Outdated Show resolved Hide resolved
src/pip/_internal/network/auth.py Outdated Show resolved Hide resolved
pradyunsg
pradyunsg approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a non-blocking concern.

@q0w q0w closed this Apr 7, 2022
@q0w q0w reopened this Apr 7, 2022
@pradyunsg pradyunsg merged commit eacc739 into pypa:main Apr 8, 2022
@q0w q0w mentioned this pull request Apr 11, 2022
Open
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr left review comments

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authentication prioritize .netrc credentials over ones from url.
3 participants
@q0w @uranusjr @pradyunsg