Add download_info: DirectUrl to InstallRequirement #11137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pypa/pip-committers before I write the last tests, if anyone is not on board with this approach, please say so :) |
sbidoul
force-pushed
the
download-info-sbi
branch
from
3342b3b
to
e744949
Compare
uranusjr
approved these changes
May 30, 2022
This should not matter in practice but let's be correct. Since there is always a cache (the transient or persistent cache), only the persistent cache matters when deciding if something is actually cached.
|
I'm going ahead and merging this one. Thanks for the review, @uranusjr ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
download_info: DirectUrlproperty toInstallRequirement.It is populated
origin.jsonfile in wheel cache entries (2nd commit)Note it is always set, i.e. whether the requirement was provided as a direct URL or obtained from an index or find-links.
This property is therefore guaranteed to be set after the resolution step and can be used to produce an installation report containing the URL and hash of downloaded artifacts. Towards #10771 (comment).
Having the original artifact URL (and hash if applicable) recorded in the wheel cache also means we can use it to not disable the wheel cache when hash verification is requested. Towards #5037.
Creating as draft as this needs tests for the interactions with the wheel cache.