Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isolated environment scripts path on Debian #11623

Merged
merged 4 commits into from
Jan 4, 2023

Commits on Dec 27, 2022

  1. Fix isolated environment scripts path on Debian

    The scripts path was looked up passing explicitly the scheme to be
    used using "nt" on Windows and "posix_prefix" everywhere else.
    However, when the isolated build environment is created, packages are
    installed using the default scheme for the platform. On most platforms
    this works because normally "nt" and "posix_prefix" are the default
    schemes.
    
    However, Debian customizes sysconfig to use a "posix_local" scheme by
    default and under this scheme the scripts path does not match the one
    of the "posix_prefix" scheme. This results in scripts installed as
    part of the build dependencies not to be found during the build, as
    reported here mesonbuild/meson-python#109
    and here https://bugs.debian.org/1019293.
    
    The problem can be solved omitting to specify a scheme when looking up
    the scripts path. To future proof the path lookup, use the "venv"
    scheme if available as done in pypa#11598. For uniformity use similar
    functions as used to lookup the library paths.
    dnicolodi committed Dec 27, 2022
    Configuration menu
    Copy the full SHA
    da47881 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2022

  1. Configuration menu
    Copy the full SHA
    77ef9f0 View commit details
    Browse the repository at this point in the history
  2. Avoid unnecessary indirection

    Since there's not equivalent of get_isolated_environment_bin_path for
    the distutils backend, the additional declaretion in the sysconfig
    backend is unnecessary.
    uranusjr committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    28e5eb9 View commit details
    Browse the repository at this point in the history
  3. Reorder __all__

    The list is *almost* sorted alphabetically so let's make it fully so.
    uranusjr committed Dec 28, 2022
    Configuration menu
    Copy the full SHA
    a0c607f View commit details
    Browse the repository at this point in the history