Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention setup.py develop change in 23.1 changelog #11973

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Mention setup.py develop change in 23.1 changelog #11973

merged 2 commits into from
Apr 17, 2023

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Apr 17, 2023

Update changelog to mention that setup.py develop is not used anymore if wheel is not installed.

Tentatively assigning to 23.1 in case we have a bugfix release to do.

@sbidoul sbidoul added this to the 23.1 milestone Apr 17, 2023
@sbidoul sbidoul requested a review from pfmoore April 17, 2023 11:56
@sbidoul sbidoul added the skip news Does not need a NEWS file entry (eg: trivial changes) label Apr 17, 2023
@sbidoul sbidoul marked this pull request as ready for review April 17, 2023 11:57
@pfmoore
Copy link
Member

pfmoore commented Apr 17, 2023

LGTM, although I'm cautiously optimistic that we won't need a 23.1.1, as there haven't been any screams of anguish so far 😉1

Footnotes

  1. That statement's just asking for trouble, isn't it?!! ↩

@pradyunsg pradyunsg changed the title Mention setup.py develop change in 23.1 changelog Mention setup.py develop change in 23.1 changelog Apr 17, 2023
@pradyunsg pradyunsg merged commit b9c1097 into pypa:main Apr 17, 2023
@sbidoul sbidoul deleted the update-231-changelog-sbi branch April 17, 2023 14:45
@pfmoore
Copy link
Member

pfmoore commented Apr 17, 2023

That statement's just asking for trouble, isn't it?!!

Sigh, #11975 🙁

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pfmoore pfmoore pfmoore approved these changes

Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
23.1
Development

Successfully merging this pull request may close these issues.
3 participants
@sbidoul @pfmoore @pradyunsg