Update and provide fixes for mypy pre-commit #12389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notatallshaw
force-pushed
the
update-mypy
branch
from
bbd8ba8
to
ac2c42c
Compare
uranusjr
approved these changes
Nov 6, 2023
uranusjr
reviewed
Nov 7, 2023
| @@ -941,7 +945,7 @@ def html_index_with_onetime_server( | |||
| """ | |||
|
|
|||
| class InDirectoryServer(http.server.ThreadingHTTPServer): | |||
| def finish_request(self, request: Any, client_address: Any) -> None: | |||
| def finish_request(self: "Self", request: Any, client_address: Any) -> None: | |||
There was a problem hiding this comment.
Why Mypy requires this change I don’t understand
There was a problem hiding this comment.
Without it the call below it:
self.RequestHandlerClass(
request,
client_address,
self,
directory=str(html_index_for_packages), # type: ignore[call-arg]
)Causes the mypy error:
tests/conftest.py:952: error: Argument 3 has incompatible type
"InDirectoryServer"; expected "Self" [arg-type]
self,
^~~~
I did not investigate why mypy now requires self in this case to be type hinted.
There was a problem hiding this comment.
Yeah I kind of understand the reason Mypy needs it, but it really shouldn’t need it. It could be a bug.
|
Merging this on the basis of the approvals here. |
fridex
pushed a commit
to fridex/pip
that referenced
this pull request
Nov 8, 2023
* Update mypy to 1.6.1 * Fix mypy "Source file found twice under different module names" error * Ignore type of intialized abstract class in tests * Use more specific type ignore method-assign * Type ignore for message.get_all * Remove unused type ignore * Add SizedBuffer type for xmlrpc.client.Transport subclass * Add Self type for RequestHandlerClass in test * Add type ignore for shutil.rmtree onexc handler * Quote SizedBuffer * Add news entry * Remove no longer correct comment * Update self import * Also ignore type onerror=handler * Update news entry * Update news entry
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update and provide fixes for mypy pre-commit
When running pre-commit locally with Python 3.12 on Pip main I am getting the error:
I assume this is because the version of MyPy in the pre-commit is quite old. I updated it and then went through all the new errors it produced trying to fix them as seemed most appropriate.
I ended up having to add a type-ignore on this line regardless as although it now recognizes onexc it can not translate the type: