-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Python Support Policy #12529
Update Python Support Policy #12529
Conversation
08e0803
to
57b2d8c
Compare
57b2d8c
to
b217d29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit about how we spell pip, ignore if you'd prefer not to worry about that for now.
@@ -93,8 +93,13 @@ issues by pip's maintainers. | |||
Python Support Policy | |||
--------------------- | |||
|
|||
In general, a given Python version is supported until its usage on PyPI falls below 5%. | |||
This is at the maintainers' discretion, in case extraordinary circumstances arise. | |||
pip supports `CPython versions that are not end-of-life`_. Older versions of CPython may |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip supports `CPython versions that are not end-of-life`_. Older versions of CPython may | |
Pip supports `CPython versions that are not end-of-life`_. Older versions of CPython may |
Minor nit - I don't think we have a policy that "pip" is always in lower case? Certainly, I don't follow this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually followed the pattern of the previous section which started the sentence with a lower case pip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, apparently there is even a written tentative convention to always write pip lower case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure I added "tentative" there because Paul and I had a disagreement about this. 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol yeah, I recall now. I find "all lowercase" conventions to be awkward and (to be blunt) a little pretentious. If "pip" is a proper noun, it should either be capitalised all the time, as Pip
(like place and person names), or capitalised like any other noun, at the start of a sentence but not otherwise (which is what I prefer). If it's an acronym ("pip installs packages") it should be all-caps ("PIP"), but I don't think that anyone sees it that way.
I'm never going to follow a requirement to lowercase "pip" at the start of a sentence, but I don't care enough to try to force my views on other people, if they prefer to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I promise I have no opinion whatsover about this :) I'll merge as is for consistency because I'm lazy.
statistics on PyPI, Python versions supported by the vendored dependencies and | ||
maintenance burden). | ||
|
||
pip maintainers accept pull requests to support other Python implementations, but the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip maintainers accept pull requests to support other Python implementations, but the | |
Pip maintainers accept pull requests to support other Python implementations, but the |
(edited the description, so that it closes a similar but different PR that I'd filed) |
Closes #12450