Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python Support Policy #12529

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Feb 17, 2024

Closes #12450

Copy link
Member

@pfmoore pfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit about how we spell pip, ignore if you'd prefer not to worry about that for now.

@@ -93,8 +93,13 @@ issues by pip's maintainers.
Python Support Policy
---------------------

In general, a given Python version is supported until its usage on PyPI falls below 5%.
This is at the maintainers' discretion, in case extraordinary circumstances arise.
pip supports `CPython versions that are not end-of-life`_. Older versions of CPython may
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip supports `CPython versions that are not end-of-life`_. Older versions of CPython may
Pip supports `CPython versions that are not end-of-life`_. Older versions of CPython may

Minor nit - I don't think we have a policy that "pip" is always in lower case? Certainly, I don't follow this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually followed the pattern of the previous section which started the sentence with a lower case pip.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, apparently there is even a written tentative convention to always write pip lower case.

Copy link
Member

@pradyunsg pradyunsg Feb 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure I added "tentative" there because Paul and I had a disagreement about this. 😂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol yeah, I recall now. I find "all lowercase" conventions to be awkward and (to be blunt) a little pretentious. If "pip" is a proper noun, it should either be capitalised all the time, as Pip (like place and person names), or capitalised like any other noun, at the start of a sentence but not otherwise (which is what I prefer). If it's an acronym ("pip installs packages") it should be all-caps ("PIP"), but I don't think that anyone sees it that way.

I'm never going to follow a requirement to lowercase "pip" at the start of a sentence, but I don't care enough to try to force my views on other people, if they prefer to do so.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I promise I have no opinion whatsover about this :) I'll merge as is for consistency because I'm lazy.

statistics on PyPI, Python versions supported by the vendored dependencies and
maintenance burden).

pip maintainers accept pull requests to support other Python implementations, but the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip maintainers accept pull requests to support other Python implementations, but the
Pip maintainers accept pull requests to support other Python implementations, but the

@pradyunsg
Copy link
Member

(edited the description, so that it closes a similar but different PR that I'd filed)

@sbidoul sbidoul merged commit 76554a4 into pypa:main Feb 17, 2024
12 checks passed
@sbidoul sbidoul deleted the update-python-support-policy branch February 17, 2024 18:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants