Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer removal of --build-option and --global-option to 25.0 #12837

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ichard26
Copy link
Member

@ichard26 ichard26 commented Jul 8, 2024

We aren't in a rush to remove these and setuptools still isn't ready.

Should I add a changelog entry @sbidoul? I see that you didn't in #12492.

We aren't in a rush to remove these and setuptools still isn't ready.
@ichard26 ichard26 added skip news Does not need a NEWS file entry (eg: trivial changes) type: deprecation Related to deprecation / removal. labels Jul 8, 2024
@sbidoul
Copy link
Member

sbidoul commented Jul 8, 2024

Should I add a changelog entry @sbidoul? I see that you didn't in #12492.

I don't have a strong opinion on this. I'd say it's not worth it: it was deprecated and still is, so no practical difference for the user.

@sbidoul sbidoul added this to the 24.2 milestone Jul 8, 2024
@pradyunsg pradyunsg merged commit 34e70ba into pypa:main Jul 9, 2024
29 of 30 checks passed
@ichard26 ichard26 deleted the defer-11859 branch July 9, 2024 02:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes) type: deprecation Related to deprecation / removal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants