-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions: Replace deprecated macos-12 with macos-13 #12951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I planned to address this at some point, but then completely forgot. Thanks! :)
macOS-12 builds are now taking over 3 hours, because homebrew support has been dropped, so the first step in the build involves compiling llvm and rust from scratch. The following message appears in the build logs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending CI
And CI is green :) |
https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/
We currently test macos-12 (Intel) and macos-latest (M1), so replace macos-12 with macos-13 to retain Intel + M1 testing.