Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for explicit PIP_IS_CI environment variable to report automated installs to Warehouse. #6522

Merged
merged 1 commit into from
May 24, 2019
Merged

Check for explicit PIP_IS_CI environment variable to report automated installs to Warehouse. #6522

merged 1 commit into from
May 24, 2019

Conversation

theacodes
Copy link
Member

Closes #5499

@cjerdonek
Copy link
Member

I would also update the test to include this case. You can look at the original PR for where the test is located: #6273

@theacodes
Copy link
Member Author

I swear I looked everywhere for that. thanks for pointing me in the right direction, will happily add the test case tomorrow. :)

@theacodes
Copy link
Member Author

@cjerdonek done. :)

@cjerdonek
Copy link
Member

Thanks! Let's see what people say here in case people think the name should be changed: #5499 (comment)

@theacodes
Copy link
Member Author

theacodes commented May 23, 2019 via email

@cjerdonek
Copy link
Member

So it can be seen here without having to click through, on the other issue in response to a point / question made by @methane, I'm thinking we should consider naming this PIP_IS_AUTOMATED (or something similar) instead of PIP_IS_CI.

@theacodes
Copy link
Member Author

@cjerdonek Done!

@theacodes theacodes changed the title Check for explicit PIP_IS_CI environment variable to report automated installs to Warehouse. Check for explicit PIP_IS_AUTOMATED environment variable to report automated installs to Warehouse. May 23, 2019
@theacodes theacodes changed the title Check for explicit PIP_IS_AUTOMATED environment variable to report automated installs to Warehouse. Check for explicit PIP_IS_AUTOMATED environment variable to report automated installs to Warehouse. May 23, 2019
@cjerdonek cjerdonek added type: enhancement Improvements to functionality type: maintenance Related to Development and Maintenance Processes labels May 24, 2019
@cjerdonek
Copy link
Member

Hi @theacodes, sorry, I didn't mean you had to change your PR. I was just saying how I was leaning while waiting for people who would know better to chime in on the other thread. Based on @njsmith's reply, the environment variable name should go back to PIP_IS_CI I think.

@theacodes
Copy link
Member Author

inout

@theacodes theacodes changed the title Check for explicit PIP_IS_AUTOMATED environment variable to report automated installs to Warehouse. Check for explicit PIP_IS_CI environment variable to report automated installs to Warehouse. May 24, 2019
@theacodes
Copy link
Member Author

Done.

@cjerdonek
Copy link
Member

I just tweaked the news entry if that's okay, and then I'll merge.

@theacodes
Copy link
Member Author

theacodes commented May 24, 2019 via email

@cjerdonek cjerdonek merged commit ba53909 into pypa:master May 24, 2019
@cjerdonek
Copy link
Member

Thanks, @theacodes!

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xavfernandez xavfernandez xavfernandez approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation type: enhancement Improvements to functionality type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Differentiating organic vs automated installations
3 participants
@theacodes @cjerdonek @xavfernandez