Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error message for invalid requirements files in certain situations #6613

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Improve the error message for invalid requirements files in certain situations #6613

merged 1 commit into from
Jun 17, 2019

Conversation

cjerdonek
Copy link
Member

Fixes #6527.

@cjerdonek cjerdonek mentioned this pull request Jun 15, 2019
Closed
@cjerdonek cjerdonek added C: requirement file Using `requirements.txt` type: enhancement Improvements to functionality labels Jun 15, 2019
@cjerdonek cjerdonek added this to the Print Better Error Messages milestone Jun 15, 2019
@cjerdonek cjerdonek force-pushed the requirements-file-error branch 2 times, most recently from 85ff660 to 85325b6 Compare June 15, 2019 17:44
@cjerdonek
Copy link
Member Author

Ping, @pradyunsg. Can you take a look?

pradyunsg
pradyunsg approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjerdonek
Copy link
Member Author

Thanks!

@cjerdonek cjerdonek merged commit 6ac468e into pypa:master Jun 17, 2019
@cjerdonek cjerdonek deleted the requirements-file-error branch June 17, 2019 03:09
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jul 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: requirement file Using `requirements.txt` type: enhancement Improvements to functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error message for invalid requirements files
2 participants
@cjerdonek @pradyunsg