Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canonicalize FrozenRequirement name for correct comparison #6857

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Canonicalize FrozenRequirement name for correct comparison #6857

merged 1 commit into from
Oct 18, 2019

Conversation

abs51295
Copy link
Contributor

Fixes #5716

@abs51295 abs51295 mentioned this pull request Aug 11, 2019
Closed
@abs51295 abs51295 changed the title Canonicalize FrozenRequirement name for correct comparison [WIP] Canonicalize FrozenRequirement name for correct comparison Aug 11, 2019
@abs51295 abs51295 force-pushed the fix-pip-freeze branch 2 times, most recently from 3a63789 to f38b729 Compare August 11, 2019 10:28
@abs51295 abs51295 changed the title [WIP] Canonicalize FrozenRequirement name for correct comparison Canonicalize FrozenRequirement name for correct comparison Aug 11, 2019
chrahunt
chrahunt suggested changes Aug 12, 2019
View reviewed changes
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments.

This will also need tests. For example, you could factor tests/functional/test_freeze.py::test_freeze_with_requirement_option into a separate function then call it from a test function that passes the original text for hint.txt and another test function that calls it with the same contents but different capitalization of package names.

src/pip/_internal/operations/freeze.py Outdated Show resolved Hide resolved
src/pip/_internal/operations/freeze.py Outdated Show resolved Hide resolved
@abs51295 abs51295 force-pushed the fix-pip-freeze branch 2 times, most recently from 902ba9a to af7cc63 Compare August 31, 2019 14:18
chrahunt
chrahunt approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chrahunt chrahunt merged commit 24c9daa into pypa:master Oct 18, 2019
@chrahunt
Copy link
Member

Thanks for your work on this @abs51295!

@abs51295
Copy link
Contributor Author

Thank you for your review and patience @chrahunt :)

@chrahunt chrahunt mentioned this pull request Oct 18, 2019
Merged
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Nov 17, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrahunt chrahunt chrahunt approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip freeze does case sensitive comparsion
2 participants
@abs51295 @chrahunt