Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate git+git@ form of VCS requirements #7543

Merged
merged 3 commits into from
Jan 8, 2020

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jan 2, 2020

See #6293, #2038

The git+git@ form of VCS pseudo-URL seems to be supported for editable installs only. Everywhere else, proper URLs are required.

This might be accidental and due to a less strict VCS URL detection mechanism for editable installs.

Since this creates bugs (in pip freeze) and confusion, let's progressively require proper URLs for editable installs too.

I propose a 1 year deprecation period.

@sbidoul sbidoul changed the title Deprecate git+git@ form of VCS url Deprecate git+git@ form of VCS requirements Jan 2, 2020
@sbidoul sbidoul added type: deprecation Related to deprecation / removal. C: vcs pip's interaction with version control systems like git, svn and bzr labels Jan 2, 2020
@sbidoul sbidoul force-pushed the deprecate-gitgitarobase-sbi branch 2 times, most recently from 806bfa2 to b84c4f1 Compare January 2, 2020 17:45
news/7543.removal Outdated Show resolved Hide resolved
src/pip/_internal/req/req_install.py Outdated Show resolved Hide resolved
@sbidoul sbidoul added this to the 20.0 milestone Jan 5, 2020
@chrahunt chrahunt merged commit eeeecbe into pypa:master Jan 8, 2020
@chrahunt
Copy link
Member

chrahunt commented Jan 8, 2020

It looks like all feedback has been resolved, so I will merge this.

Thank you @sbidoul

@sbidoul sbidoul deleted the deprecate-gitgitarobase-sbi branch January 8, 2020 06:55
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Feb 8, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: vcs pip's interaction with version control systems like git, svn and bzr type: deprecation Related to deprecation / removal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants