Requires-Python implementation, take 2 #7960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a dist contains Requires-Python metadata, it is converted into a Requirement for the resolver based on whether the Requires-Python is compatible or not. If it is compatible, an ExplicitRequirement is returned to hold the Python information (either sys.version_info, or the user-supplied --python-version). If it is incompatible, a special NoMatchRequirement is returned, which never matches to anything, generating a ResolutionImpossible to report the Python version incompatibility. The --ignore-requires-python flag is implemented as to not return a Requirement for Requires-Python at all.
uranusjr
added
the
skip news
uranusjr
force-pushed
the
requires-python-2
branch
from
4fe167a
to
65ffd33
Compare
pradyunsg
approved these changes
Apr 2, 2020
pfmoore
reviewed
Apr 2, 2020
pfmoore
approved these changes
Apr 2, 2020
|
LGTM, I'll merge once CI completes |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see discussions in uranusjr@632df57