Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if package url is a vcs or an archive url with invalid scheme #8465

Merged
merged 5 commits into from
Jun 29, 2020
Merged

Warn if package url is a vcs or an archive url with invalid scheme #8465

merged 5 commits into from
Jun 29, 2020

Conversation

deveshks
Copy link
Contributor

Fixes #8128

@deveshks deveshks mentioned this pull request Jun 18, 2020
Closed
@deveshks deveshks requested a review from uranusjr June 19, 2020 05:07
@deveshks
Copy link
Contributor Author

Thanks for the approval @uranusjr.

@pradyunsg I think this should be ready to merged

@deveshks
Copy link
Contributor Author

Hi @pradyunsg ,

I believe this should be ready to merge, perhaps after another review from your end.

pradyunsg
pradyunsg approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor change.

src/pip/_internal/index/collector.py Outdated Show resolved Hide resolved
@pradyunsg pradyunsg merged commit 17608c4 into pypa:master Jun 29, 2020
@deveshks deveshks deleted the collector-debug-to-warn branch June 29, 2020 18:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch log level of messages in pip._internal.index.collector._get_html_page from debug to warning
3 participants
@deveshks @uranusjr @pradyunsg