Canonicalize name in check_if_exists #8659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation uses pkg_resources.get_distribution(), which does not canonicalize the package name correctly, and fails when combined with pip's own get_distribution(), which does canonicalize names. This makes InstallRequirement.check_if_exists() only use pip's own canonicalization logic so different package name forms are matched as expected.
|
Thanks for this. Noting here that this will also close #8550 |
sbidoul
approved these changes
Aug 1, 2020
There was a problem hiding this comment.
Change LGTM, and tested with the reproducer. Thanks @uranusjr
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Aug 4, 2020
…n-name Canonicalize name in check_if_exists
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation uses both
pkg_resources.get_distribution()and pip’s ownget_distribution(), use different name canonicalisation logic. This patch makesInstallRequirement.check_if_exists()only use pip'sown
get_distribution()so different package name forms are matched as expected.Fix #8645.