Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Skip candidate not providing valid metadata" #9293

Merged

Conversation

pradyunsg
Copy link
Member

Reverts #9264
See #9284 for context.

@pradyunsg pradyunsg force-pushed the revert-9264-new-resolver-dont-abort-on-inconsistent-candidate branch from 1dae6f5 to 7165ab8 Compare December 15, 2020 10:18
@pradyunsg
Copy link
Member Author

(waiting for CI to pass, and then I'll push the NEWS fragment)

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me. I assumed this is a git revert and only skimmed through it without comparing line-to-line, however.

@BjoernLudwigPTB
Copy link

BjoernLudwigPTB commented Dec 15, 2020

Thanks for the quick action! We are really desperately awaiting 20.3.3 release for releasing one of our packages without having to change the pipeline config.

@pradyunsg
Copy link
Member Author

Awesome. I'll cut this in a bit. Need to do some home maintenance work. :)

@pradyunsg pradyunsg merged commit b4fb710 into master Dec 15, 2020
@pradyunsg pradyunsg deleted the revert-9264-new-resolver-dont-abort-on-inconsistent-candidate branch December 15, 2020 14:19
@bl-ue
Copy link

bl-ue commented Dec 15, 2020

🎉 ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants