Verify built wheel contains valid metadata #9320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
approved these changes
Dec 19, 2020
pradyunsg
added
C: build logic
uranusjr
force-pushed
the
wheel-check-valid
branch
from
c724645
to
6902269
Compare
gst
reviewed
Dec 27, 2020
| ) | ||
| if canonicalize_version(dist.version) != canonicalize_version(w.version): | ||
| raise InvalidWheelFilename( | ||
| "Wheel has unexpected file name: expected {!r}, " |
There was a problem hiding this comment.
The technically correct expression is “the version field in the file name” but that’s probably too long and not comprehensible to typical users.
|
I'm glad this got fixed so quickly! Thanks @uranusjr! Any idea if this PR will make it into the next release? |
|
My hope is to include this in 20.3.4, but can't provide a promise or timeline. The release manager is in charge of those. |
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Jan 23, 2021
Verify built wheel contains valid metadata
jsirois
added a commit
to pex-tool/pip
that referenced
this pull request
Feb 1, 2021
* Merge pull request pypa#9289 from uranusjr/new-resolver-lazy-insert * Merge pull request pypa#9315 from pradyunsg/better-search-errors * Merge pull request pypa#9369 from uranusjr/resolvelib-054 * Merge pull request pypa#9320 from uranusjr/wheel-check-valid Verify built wheel contains valid metadata * Merge pull request pypa#9432 from uranusjr/new-resolver-dedup-on-backtracking Avoid downloading multiple candidates of a same version * Revert "Remove on_returncode parameter from call_subprocess" This reverts commit ab3ee71. * Revert "Remove show_stdout from run_command args" This reverts commit 94882fd. * Revert "Create call_subprocess just for vcs commands" This reverts commit 8adbc21. * Revert "Improve check for svn version string" This reverts commit 1471897. * Revert "Bubble up SubProcessError to basecommand._main" This reverts commit e9f738a. * Additional revert of 7969 Revert additional changes that were made after 7969 and depended on it. * add stdout_only to call_subprocess * vcs: capture subprocess stdout only * Add test for call_subprocess stdout_only * Bump for release * Fix test bitrot. Setuptools released 52.0.0 which killed easy_install support and thus caused tests exercising easy_install to fail. Co-authored-by: Pradyun Gedam <[email protected]> Co-authored-by: Stéphane Bidoul <[email protected]> Co-authored-by: Pradyun Gedam <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9206 and unblock #9199.