Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when doing a PEP 517 build in presence of --global-option #9774

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Warn when doing a PEP 517 build in presence of --global-option #9774

merged 2 commits into from
Apr 14, 2021

Commits on Apr 4, 2021

  1. PEP 517 + --build-option is now a warning 

    We warn instead of erroring out when --build-option is present
when doing a PEP 517 build. There is no strong reason to error
out, and this will avoid backward compatibility issues when we
support build options in requirement files and installation.
    @sbidoul
    sbidoul committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    69dee62 View commit details
    Browse the repository at this point in the history

  2. PEP 517 build in presence of --global-option emits a warning 

    So these are not ignored silently.
    @sbidoul
    sbidoul committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    7c6ee48 View commit details
    Browse the repository at this point in the history