Skip to content

Commit

Permalink
Disable lint in CI - temporarily
Browse files Browse the repository at this point in the history
  • Loading branch information
oz123 committed Jan 28, 2023
1 parent 8a2c5df commit 3b604f5
Show file tree
Hide file tree
Showing 3 changed files with 47 additions and 43 deletions.
82 changes: 42 additions & 40 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,47 +40,49 @@ on:
permissions:
contents: read # to fetch code (actions/checkout)
jobs:
lint:
name: Check code linting
runs-on: ubuntu-latest
env:
PIPENV_DEFAULT_PYTHON_VERSION: ${{ matrix.python-version }}
PYTHONWARNINGS: ignore:DEPRECATION
PYTHONIOENCODING: "utf-8"
GIT_ASK_YESNO: "false"
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: 3.x
- name: Collect Workflow Telemetry
uses: runforesight/foresight-workflow-kit-action@v1
if: ${{ always() }}
with:
api_key: ${{ secrets.FORESIGHT_API_KEY }}
- run: |
python -m pip install pre-commit
pre-commit run --all-files --verbose --show-diff-on-failure
vendor:
name: Vendoring
needs: lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: "3.10"
- name: Collect Workflow Telemetry
uses: runforesight/foresight-workflow-kit-action@v1
if: ${{ always() }}
with:
api_key: ${{ secrets.FORESIGHT_API_KEY }}
- run: |
python -m pip install --upgrade wheel invoke parver bs4 vistir towncrier requests parse
python -m invoke vendoring.update
# temporarily disable lint, since we can't install it in CI
# see https://github.com/PyCQA/isort/pull/2078
#lint:
# name: Check code linting
# runs-on: ubuntu-latest
# env:
# PIPENV_DEFAULT_PYTHON_VERSION: ${{ matrix.python-version }}
# PYTHONWARNINGS: ignore:DEPRECATION
# PYTHONIOENCODING: "utf-8"
# GIT_ASK_YESNO: "false"
# steps:
# - uses: actions/checkout@v3
# - uses: actions/setup-python@v4
# with:
# python-version: 3.x
# - name: Collect Workflow Telemetry
# uses: runforesight/foresight-workflow-kit-action@v1
# if: ${{ always() }}
# with:
# api_key: ${{ secrets.FORESIGHT_API_KEY }}
# - run: |
# python -m pip install pre-commit
# pre-commit run --all-files --verbose --show-diff-on-failure
#vendor:
# name: Vendoring
# needs: lint
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v3
# - uses: actions/setup-python@v4
# with:
# python-version: "3.10"
# - name: Collect Workflow Telemetry
# uses: runforesight/foresight-workflow-kit-action@v1
# if: ${{ always() }}
# with:
# api_key: ${{ secrets.FORESIGHT_API_KEY }}
# - run: |
# python -m pip install --upgrade wheel invoke parver bs4 vistir towncrier requests parse
# python -m invoke vendoring.update
tests:
name: ${{matrix.os}} / ${{ matrix.python-version }}
needs: lint
# needs: lint
runs-on: ${{ matrix.os }}-latest
strategy:
fail-fast: false
Expand Down Expand Up @@ -155,7 +157,7 @@ jobs:

build:
name: Build Package
needs: lint
#needs: lint
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ exclude: '^(pipenv/patched/|pipenv/vendor/|tests/|pipenv/pipenv.1)'

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.1.0
rev: v4.4.0
hooks:
- id: check-builtin-literals
- id: check-added-large-files
Expand All @@ -23,7 +23,7 @@ repos:
- id: black

- repo: https://github.com/PyCQA/flake8
rev: 4.0.1
rev: 5.0.4
hooks:
- id: flake8
additional_dependencies: [
Expand All @@ -34,7 +34,7 @@ repos:
exclude: tests/data

- repo: https://github.com/PyCQA/isort
rev: 5.10.1
rev: 5.11.4
hooks:
- id: isort
files: \.py$
Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ exclude = '''
| pyproject.toml
)
'''
[tool.poetry.extras]
pipfile_deprecated_finder = ["pipreqs", "requirementslib", "pip-shims"]

[tool.isort]
atomic = true
Expand Down

0 comments on commit 3b604f5

Please sign in to comment.