Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix nondeterminism with environment markers #5239 (#5286)" #5306

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

matteius
Copy link
Member

This reverts commit 4b9fc02.

@oz123 @bakhtiary -- this reverts: #5286

because the change made here is actually fixing the issue and @dqkqd did some testing without this changeset and it was not required for fixing the issue: #5299 (comment)

I appreciate your effort to make pipenv better, please keep it up! In this case, given some additional comments that came in on that PR and the added complexity that was not required, I think we should revert it.

@matteius matteius requested a review from oz123 August 29, 2022 00:46
@oz123
Copy link
Contributor

oz123 commented Aug 29, 2022

In a away I think it's ok to revert. However, I liked the idea of using the dictionary keys for an ordered-set.

We will have to watch it for a while. I suspect that working with ordered set of depends is better.

@matteius matteius merged commit 0d86629 into main Aug 29, 2022
@matteius matteius deleted the revert-first-nondeterminism-PR branch August 29, 2022 13:19
yeisonvargasf pushed a commit to yeisonvargasf/pipenv that referenced this pull request Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants