Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for issue where requirement is a file or URL but does conntain hashes. #5327

Merged
merged 9 commits into from
Sep 3, 2022

Conversation

matteius
Copy link
Member

@matteius matteius commented Sep 3, 2022

there are actually a couple of fixes here, one is that sometimes the file URL contains hashes so we should include that with the group with hashes like we did in 2022.8.31 by accident. Also the filters after need to detect this additional part of the conditional and that change was missing in #5326.

The issue

#5306

@matteius
Copy link
Member Author

matteius commented Sep 3, 2022

Gitlab is having mainteance so the repository for flake8 is unavailable for the next ~180 minutes while they upgrade their database.

@matteius matteius requested a review from oz123 September 3, 2022 13:39
@oz123 oz123 merged commit 7d80a7f into main Sep 3, 2022
@oz123 oz123 deleted the issue-5326 branch September 3, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants