Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing from tarball fails on 2022.09.02 #5326

Closed
alexkahn-tempus opened this issue Sep 2, 2022 · 4 comments
Closed

Installing from tarball fails on 2022.09.02 #5326

alexkahn-tempus opened this issue Sep 2, 2022 · 4 comments
Labels
Type: Bug 🐛 This issue is a bug. Type: Regression This issue is a regression of a previous behavior.

Comments

@alexkahn-tempus
Copy link

alexkahn-tempus commented Sep 2, 2022

Issue description

Whilst installing via RUN PIPENV_VENV_IN_PROJECT=1 pipenv install --deploy --verbose

I have a requirement: en-core-sci-md = {file = "https://s3-us-west-2.amazonaws.com/ai2-s2-scispacy/releases/v0.4.0/en_core_sci_md-0.4.0.tar.gz"}

But it does not appear in my virtualenv upon:

import spacy
spacy.load("en_core_sci_md")

Expected result

I expected my docker image to have a dependency in the appropriate site-packages folder when installation finished.

Actual result

The dependency was not available and did not exist in the site-packages folder.

Steps to replicate

Pipfile entry:

en-core-sci-md = {file = "https://s3-us-west-2.amazonaws.com/ai2-s2-scispacy/releases/v0.4.0/en_core_sci_md-0.4.0.tar.gz"}

Corresponding lockfile entry:

        "en-core-sci-md": {
            "file": "https://s3-us-west-2.amazonaws.com/ai2-s2-scispacy/releases/v0.4.0/en_core_sci_md-0.4.0.tar.gz",
            "hashes": [
                "sha256:9ca2cf8f3b066d0a7e69c10d9cca8822bcfa7fb8c9772bc90f8780629a81e974"
            ],
            "version": "==0.4.0"
        },

Running pipenv install --verbose caused this entry:

Writing supplied requirement line to temporary file: 'https://s3-us-west-2.amazonaws.com/ai2-s2-scispacy/releases/v0.4.0/en_core_sci_md-0.4.0.tar.gz'

But it did not appear later in the output.

Reverting to 2022.08.31 solved the issue temporarily.

❤️ The project and the maintainers, thanks so much for all your work!

@matteius
Copy link
Member

matteius commented Sep 3, 2022

Thanks for the report @alexkahn-tempus -- I see what the issues are, and opened a PR. Gitlab is doing mainteance so I'll try to run the checks again later. #5327

@matteius matteius added Type: Bug 🐛 This issue is a bug. Type: Regression This issue is a regression of a previous behavior. labels Sep 3, 2022
@oz123
Copy link
Contributor

oz123 commented Sep 3, 2022

This PR is merged.

@matteius
Copy link
Member

matteius commented Sep 4, 2022

Hey @alexkahn-tempus 2022.9.4 was made specifically for this fix.

@matteius matteius closed this as completed Sep 4, 2022
@alexkahn-tempus
Copy link
Author

Thank so much @matteius and @oz123 - I'll update my production systems and loop back if there is anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 This issue is a bug. Type: Regression This issue is a regression of a previous behavior.
Projects
None yet
Development

No branches or pull requests

3 participants