-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
respect pip configuration at Pipfile creation #1008
Conversation
Respect pip index configuration (pip.conf or environment variable) when creating a new Pipfile
I feel like I should add some tests here |
Hey @hrbonz thanks for putting this together. Unfortunately altering which source is added to the Pipfile doesn’t quite respect |
@techalchemy unfotunately, That is the base of the issue I described in #856 |
@hrbonz I see what you're saying, but I'm not actually sure this is the right approach here. It's not clear that we actually want to always fall back to the default indexes in the host pip config, since I'm not sure that provides sufficient portability. I do think we would want to respect environment settings, however, but I think there is some discussion to have here (e.g. in #988 this came up) We have broader design questions to answer but for now, I would be much more prepared to accept something that prioritizes environment level settings (e.g. |
And before you rework, /cc @nateprewitt would you be willing to approve a PR to use |
We should honor the environment variable instead. |
not today, but thank you |
There must be something I don't get, why force users to set an environment variable when there is already a configuration for a standard tool that gives you this information? This is, moreover, the tool you use under the hood. |
Respect pip index configuration (pip.conf or environment variable) when
creating a new Pipfile.
I'm really not sure about this implementation but I wanted to start the conversation, I've made some choices that I think have a minimal impact.
I couldn't find a convenient method in the
pip
project that would just hand me out the best option and respect the configuration precedence so I implemented it by hand.Change mentioned in #856