Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "run" behavior on Windows #2727

Merged
merged 4 commits into from
Aug 25, 2018
Merged

Commits on Aug 10, 2018

  1. Improve "run" behavior on Windows

    Some Windows users are used to launch files without specifying a command,
    e.g.::
    
        > my-script.py
    
    This works in the shell because Windows will automatically choose an
    command based on file association, and with newer Python versions, the Py
    Launcher (py.exe) automatically chooses the correct Python based on
    shebang-parsing.
    
    A similar syntax, unfortunately, does not currently work in Pipenv::
    
        > pipenv run my-script.py
    
    Since my-script.py will be treated as a real application by the subprocess
    module.
    
    This patch catch Windows error 193 during subprocess initialization, and
    fall back to use COMSPEC (shell=True) when it happens, to provide better
    support for this use case.
    uranusjr committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    559903f View commit details
    Browse the repository at this point in the history
  2. Better comment

    uranusjr committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    87ab5e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2018

  1. Configuration menu
    Copy the full SHA
    3a8f144 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2018

  1. Configuration menu
    Copy the full SHA
    2c41a34 View commit details
    Browse the repository at this point in the history