Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive missing values of source from existing fields #3235

Merged
merged 1 commit into from
Nov 17, 2018
Merged

Conversation

frostming
Copy link
Contributor

@techalchemy @jxltom

@jxltom
Copy link
Contributor

jxltom commented Nov 16, 2018

Nice, this is one way to solve this issue. The other way is to provide default values in Pipfile.lock when converting Pipfile, which has missing fields, to Pipfile.lock.

@frostming frostming merged commit 301e4a9 into master Nov 17, 2018
@frostming frostming deleted the bugfix/3233 branch November 17, 2018 08:28
@techalchemy
Copy link
Member

Thanks for the fix, I'm good with this... @jxltom I'm happy to add you as a maintainer BTW -- are you on slack at all?

@jxltom
Copy link
Contributor

jxltom commented Nov 19, 2018

@techalchemy That will be awesome. Email [email protected] or username jxltom should find me on slack. :D

@techalchemy
Copy link
Member

We are on the PySlackers slack (https://pyslackers.com) — we just have a channel so I can’t invite you directly

@jxltom
Copy link
Contributor

jxltom commented Nov 19, 2018

I'm in, already sent you a hello message 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants