Fix #4615 - Improve sanitization to allow virtualenv paths with () and [] characters to activate #4616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Fixes #4615.
Related to #4538.
The fix
Added proper character escaping for
()
and[]
characters in virtualenv paths, by modifying the regex in_get_activate_script()
inpipenv/shells.py
.Also improved sanitization in
_sanitize()
ofProject
class inpipenv/project.py
to turn()
and[]
characters into_
.These changes allows virtualenv paths with such characters to properly activate.
The checklist
news/
directory to describe this fix with the extension.bugfix
,.feature
,.behavior
,.doc
..vendor
. or.trivial
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.