Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use sys.executable when inside a venv #4853

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Don't use sys.executable when inside a venv #4853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfa7107
Don't use sys.executable when inside virtualenv
frostming Nov 9, 2021
6d207c1
Add news entry
frostming Nov 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/4852.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Don't use ``sys.executable`` when inside an activated venv.
1 change: 0 additions & 1 deletion pipenv/environments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,6 @@ def initialize(self):
self.PIPENV_VIRTUALENV = None
if "PIPENV_ACTIVE" not in os.environ and not self.PIPENV_IGNORE_VIRTUALENVS:
self.PIPENV_VIRTUALENV = os.environ.get("VIRTUAL_ENV")
self.PIPENV_USE_SYSTEM = bool(self.PIPENV_VIRTUALENV)

# Internal, tells Pipenv to skip case-checking (slow internet connections).
# This is currently always set to True for performance reasons.
Expand Down