Fix for expanding dot env variables in scripts #4979
Conversation
… they can be exapnded by os.path.expandvars
…pa/pipenv into issue-4975-env-variables-not-expanded
| @@ -2473,8 +2471,8 @@ def do_run(project, command, args, three=None, python=False, pypi_mirror=None): | |||
| project, three=three, python=python, validate=False, pypi_mirror=pypi_mirror, | |||
| ) | |||
|
|
|||
| load_dot_env(project) | |||
There was a problem hiding this comment.
I am afraid this will break the isolation in test cases. dotenv files in one test case will contaminate other cases env.
There was a problem hiding this comment.
@frostming Could you elaborate on this? Right now the test suite is passing with this change so I am not sure I understand, but maybe I do. If its a testing concern, shouldn't it be on a top level test fixture to cleanup the environment before or after each test?
There was a problem hiding this comment.
The issue without this change is that environment that gets used for running the script is the environment without the dotenv variables. Is there a better way to accomplish it?
There was a problem hiding this comment.
shouldn't it be on a top level test fixture to cleanup the environment before or after each test?
Oh yeah, it is cleaned up.
Ensure that dot env variables are actually in the real environment so they can be exapnded by os.path.expandvars
The issue
#4975
#3901
The fix
The problem is that in the current code we are loading the .env variables into a copy of the environment which is not available to
os.path.expandvarsso they are always treated as a string. This fixes that by applying it to the environment before copying it. Also refactor away some of the complexity ofload_dot_env.The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.