Vendor in pip==22.2, rename notpip -> pip and exclusively use vendored pip #5196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… LIBRARY_RENAMES.
… global rewrites.
oz123
requested changes
Jul 27, 2022
| @@ -1,29 +0,0 @@ | |||
| BSD 3-Clause License | |||
|
|
|||
There was a problem hiding this comment.
This file should not be removed.
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
| @@ -1,27 +0,0 @@ | |||
| Copyright (c) 2010 Jonathan Hartley | |||
| @@ -1,284 +0,0 @@ | |||
| A. HISTORY OF THE SOFTWARE | |||
| @@ -1,504 +0,0 @@ | |||
| GNU LESSER GENERAL PUBLIC LICENSE | |||
|
|
||
| Permission to use, copy, modify, and distribute this software for any | ||
| purpose with or without fee is hereby granted, provided that the above | ||
| copyright notice and this permission notice appear in all copies. |
|
|
||
| Apache License | ||
| Version 2.0, January 2004 | ||
| http://www.apache.org/licenses/ |
| @@ -1,18 +0,0 @@ | |||
| Permission is hereby granted, free of charge, to any person obtaining | |||
| a copy of this software and associated documentation files (the | |||
| Copyright (c) 2006-2021 by the respective authors (see AUTHORS file). | ||
| All rights reserved. | ||
|
|
||
| Redistribution and use in source and binary forms, with or without |
| @@ -1,19 +0,0 @@ | |||
| Copyright (C) 2016 Jason R Coombs <[email protected]> | |||
|
|
|||
| Permission is hereby granted, free of charge, to any person obtaining a copy of | |||
This was referenced Jul 28, 2022
|
You are right @oz123 -- I had too many changes in this PR and the vendoring process was problematic. Not sure why the rename did not work in this PR, but I used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was branched from and supersedes this PR: #5193
which had one failing test that I decided to see if upgrading to the latest pip 22.2 would fix, and it has fixed it locally -- woo-hoo!
Fixes #5188
The issue
This accomplishes the following:
notpiptopipto be clear that its a patched version ofpip._post_pip_import.patchthat overrode the standalone pip to be the user installed pip -- and instead go with the patched import to use our vendor'd pip.pip==22.2