Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with unexpected package index resolution after upgrading pip to 22.3 #5448

Merged
merged 7 commits into from
Nov 4, 2022

Conversation

matteius
Copy link
Member

@matteius matteius commented Oct 30, 2022

The issue

After upgrading pip to 22.3 there were cases where users had multiple index defined and the resolution of which index to use changed during install causing hash validation to fail.

Fixes #5444

The fix

Technically it as never that correct to be passing all sources using extra index URLs when user has default behavior of install_search_all_sources = false --
note: this won't fix what I believe to be a change in behavior to pip that may still cause issues for users that have install_search_all_sources = true however this brings the pipenv behaviors more in line with whats expected by ensuring complete isolation of the index assigned to each package.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

pipenv/core.py Outdated Show resolved Hide resolved
pipenv/core.py Show resolved Hide resolved
pipenv/core.py Show resolved Hide resolved
Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that this is fixed, and along the way we uncover some undocumented Pipefile stuff.

@oz123
Copy link
Contributor

oz123 commented Nov 4, 2022

Please cherry pick the following commit to fix the CI:
be92e26
and
6f88313
from #5450

@oz123 oz123 merged commit 678cb1f into main Nov 4, 2022
@oz123 oz123 deleted the issue-5444 branch November 4, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download source regression in 10.25
2 participants