-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update test packages to fix tests on macos-latest #1373
Conversation
emmm.... Seems updating some packages will not fix the problem, they introduce more failures. any ideas? |
Just fixed it by deleting the caches. 👍 |
Co-authored-by: Jason Lam <[email protected]>
Hi @dukecat0, thanks for the help! Could you explain a little bit why deleting the caches will fix the tests? Actually, I spend almost the whole afternoon trying to find out why the tests keep failing. :-( |
Cached packages are stored at pipx/.github/workflows/tests.yml Lines 38 to 42 in 5d610e5
Since package versions are updated here, those cached packages should be removed so that https://github.com/pypa/pipx/blob/main/scripts/update_package_cache.py will download and use the new ones. Actually the reason that I had a thought of removing cache files is I ran tests on a clean copy of pipx (without cache files) and everything worked fine, so that reminded me. However, I think we can make some improvements to avoid this in the future:
|
@dukecat0 Thanks so much for the detailed explanation! Actually, I do not have a macos so I thought it might be some kind of compatibility issue. You save my day! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
changelog.d/
(if the patch affects the end users)Summary of changes
Fix #1372
Test plan
Tested by running