Skip to content

Commit

Permalink
Fix formatting of tests and change dash deprecation method name
Browse files Browse the repository at this point in the history
  • Loading branch information
melissa-kun-li committed Mar 8, 2021
1 parent 938a339 commit 7129ad1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions setuptools/dist.py
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ def _parse_config_files(self, filenames=None): # noqa: C901
continue

val = parser.get(section, opt)
opt = self.dash_to_underscore_warning(opt, section)
opt = self.warn_dash_deprecation(opt, section)
opt = self.make_option_lowercase(opt, section)
opt_dict[opt] = (filename, val)

Expand All @@ -626,7 +626,7 @@ def _parse_config_files(self, filenames=None): # noqa: C901
except ValueError as e:
raise DistutilsOptionError(e) from e

def dash_to_underscore_warning(self, opt, section):
def warn_dash_deprecation(self, opt, section):
if section in (
'options.extras_require', 'options.data_files',
):
Expand Down
16 changes: 8 additions & 8 deletions setuptools/tests/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -507,10 +507,9 @@ def test_not_utf8(self, tmpdir):
with get_dist(tmpdir):
pass

def test_dash_to_underscore_warning(self, tmpdir):
# dash_to_underscore_warning() is a method in setuptools.dist
# remove this test and method when dash convert to underscore in setup.cfg
# is no longer supported
def test_warn_dash_deprecation(self, tmpdir):
# warn_dash_deprecation() is a method in setuptools.dist
# remove this test and the method when no longer needed
fake_env(
tmpdir,
'[metadata]\n'
Expand All @@ -523,11 +522,12 @@ def test_dash_to_underscore_warning(self, tmpdir):
with pytest.warns(UserWarning, match=msg):
with get_dist(tmpdir) as dist:
metadata = dist.metadata
assert metadata.author_email == '[email protected]'
assert metadata.maintainer_email == '[email protected]'

def test_uppercase_warning(self, tmpdir):
# remove this test and the method uppercase_warning() in setuptools.dist
assert metadata.author_email == '[email protected]'
assert metadata.maintainer_email == '[email protected]'

def test_make_option_lowercase(self, tmpdir):
# remove this test and the method make_option_lowercase() in setuptools.dist
# when no longer needed
fake_env(
tmpdir,
Expand Down

0 comments on commit 7129ad1

Please sign in to comment.