-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeError in windows / msvc.py when VCRuntimeRedist is not present #1902
Comments
multiple reports now. |
I ran into this issue too, and fixed it temporarily using: diff --git a/setuptools/msvc.py b/setuptools/msvc.py
index 2ffe1c81..ffd01704 100644
--- a/setuptools/msvc.py
+++ b/setuptools/msvc.py
@@ -1617,7 +1617,7 @@ class EnvironmentInfo:
self.FSharp],
exists),
)
- if self.vs_ver >= 14 and isfile(self.VCRuntimeRedist):
+ if self.vs_ver >= 14 and self.VCRuntimeRedist and isfile(self.VCRuntimeRedist):
env['py_vcruntime_redist'] = self.VCRuntimeRedist
return env The package (pendulum in my case) was successfully installed after this change. |
Added a workaround for a setuptools-related failure that has been observed as occurring on Windows installations, where setuptools is not correctly reporting a build error when the MSVC build dependencies are not installed and therefore not allowing graceful degradation into non C extensions builds. Setuptools issue pypa/setuptools#1902 Fixes: #4967 Change-Id: I5e21e7e78cb6d927b18afce64cacf8643b98354e
Added a workaround for a setuptools-related failure that has been observed as occurring on Windows installations, where setuptools is not correctly reporting a build error when the MSVC build dependencies are not installed and therefore not allowing graceful degradation into non C extensions builds. Setuptools issue pypa/setuptools#1902 Fixes: #4967 Change-Id: I5e21e7e78cb6d927b18afce64cacf8643b98354e (cherry picked from commit 4a2dd49)
I ran into the same issue today (platform: Windows 10) and traced it down to the fact that my Visual Studio installation had no Line 1540 in 1d03fdc
I ended up re-installing Visual Studio with all C++ development enabled. After that, the package in question ( |
Added a workaround for a setuptools-related failure that has been observed as occurring on Windows installations, where setuptools is not correctly reporting a build error when the MSVC build dependencies are not installed and therefore not allowing graceful degradation into non C extensions builds. Setuptools issue pypa/setuptools#1902 Fixes: sqlalchemy#4967 Change-Id: I5e21e7e78cb6d927b18afce64cacf8643b98354e
Hey folks, I run into this error and trying to debug it because it only appears on the CI but I cant repro on my local dev box. Is this the function that I should be looking at to figure out the way it tries to resolve the path? Line 1691 in d368be2
|
Should be fixed in v74.1.1, releasing now. |
User is reporting the below stack trace on windows. This would indicate that the method VCRuntimeRedist at https://github.com/pypa/setuptools/blob/master/setuptools/msvc.py#L1540 is returning None and the method at https://github.com/pypa/setuptools/blob/master/setuptools/msvc.py#L1574 is nonetheless assuming a non-None result.
It's very hard to find this error elsewhere but I did see it reported (and mis-diagnosed) here: https://stackoverflow.com/questions/58677600/unable-to-install-jupyterlab-for-python3-8-64bit
The text was updated successfully, but these errors were encountered: