Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools fails to build a windows python 3.5 C extension on GitHub Actions (msvc) #1903

Closed
mayeut opened this issue Nov 11, 2019 · 0 comments · Fixed by #1904
Closed

setuptools fails to build a windows python 3.5 C extension on GitHub Actions (msvc) #1903

mayeut opened this issue Nov 11, 2019 · 0 comments · Fixed by #1904

Comments

@mayeut
Copy link
Member

mayeut commented Nov 11, 2019

setuptools fails to build a windows python 3.5 C extension on GitHub Actions using provided msvc.

python 3.6, 3.7 & 3.8 do succeed meaning the proper msvc compilers are present.

Per @zooba comment, cloning the detection mechanism from CPython 3.8.0 distutils does indeed work as can be seen here where all CI tests pass (windows: TravisCI, AppVeyor, Azure Pipelines, GitHub Actions).

I do have a branch of setuptools with such a patch and will open a PR. Please note that I can't test it thoroughly cause I don't have any Windows environment at hand (except for CI which requires very long iterations).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant