Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deprecated decorator #125

Merged
merged 12 commits into from
Nov 28, 2019
Merged

Conversation

skoudoro
Copy link
Contributor

Highly inspired/copied from Nibabel, this is a utility function to prepare the deprecation of many functions/modules.
Currently, our system is quite manual and not enough rigorous so it will bring more consistency.

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #125 into master will increase coverage by 0.21%.
The diff coverage is 98.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   87.96%   88.18%   +0.21%     
==========================================
  Files          14       15       +1     
  Lines        3921     4002      +81     
  Branches      484      501      +17     
==========================================
+ Hits         3449     3529      +80     
  Misses        345      345              
- Partials      127      128       +1
Impacted Files Coverage Δ
fury/deprecator.py 100% <100%> (ø)
fury/decorators.py 100% <100%> (ø) ⬆️
fury/testing.py 89.28% <95.23%> (+3.57%) ⬆️

@skoudoro
Copy link
Contributor Author

I think I encounter the same issue as pypa/setuptools#1903, this is why python3.5 is failing on windows. Need to find a workaround.

@pep8speaks
Copy link

pep8speaks commented Nov 27, 2019

Hello @skoudoro! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-28 00:03:08 UTC

@Garyfallidis Garyfallidis merged commit 34da592 into fury-gl:master Nov 28, 2019
@skoudoro skoudoro deleted the deprecated-func branch December 1, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants