-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deprecated decorator #125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
==========================================
+ Coverage 87.96% 88.18% +0.21%
==========================================
Files 14 15 +1
Lines 3921 4002 +81
Branches 484 501 +17
==========================================
+ Hits 3449 3529 +80
Misses 345 345
- Partials 127 128 +1
|
skoudoro
force-pushed
the
deprecated-func
branch
from
November 27, 2019 19:31
d263254
to
00e6ec6
Compare
I think I encounter the same issue as pypa/setuptools#1903, this is why python3.5 is failing on windows. Need to find a workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highly inspired/copied from Nibabel, this is a utility function to prepare the deprecation of many functions/modules.
Currently, our system is quite manual and not enough rigorous so it will bring more consistency.