Enable McCabe complexity check in flake8 #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
force-pushed
the
maintenance/flake8-mccabe-complexity
branch
from
0438a04
to
e3a1d93
Compare
webknjaz
force-pushed
the
maintenance/flake8-mccabe-complexity
branch
from
e3a1d93
to
4a02c8e
Compare
webknjaz
force-pushed
the
maintenance/flake8-mccabe-complexity
branch
from
4a02c8e
to
6f74941
Compare
jaraco
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
flake8 can check code for complexity, it's the best practice to enable it.
This change makes sure to gate overly complex code guiding the contributors
to make it simpler when necessary.
It also disables the check in some places while fixing the others. I've only
simplified things that are easy to address and those changes can be easily
cherry-picked separately.
Ref: jaraco/skeleton#34
Pull Request Checklist
changelog.d/.(See documentation for details)