Attempt to re-enable Windows tests #3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to a comment in pypa/distutils#118 this problem might be solved by allowing tox to pass some environment variables.
For the time being let's just use the older version for the GHA host, so we can keep testing on Windows, instead of skipping it at all.
abravalheri
force-pushed
the
ci-fix-tests
branch
from
83f916a
to
8f3cdf7
Compare
|
Obviously, would be nice to get 2022 compatibility, but happy to restore coverage on legacy platforms in the interim. |
jaraco
approved these changes
Mar 13, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to a comment in pypa/distutils#118 this problem might beThis approach does not work.solved by allowing tox to pass some environment variables.
We can instead re-enable the tests for Windows, using 2019 (maybe that is better than skipping them completely?)
Summary of changes
Changetox.inito passPROGRAMFILES(x86)to testssee
distutils.errors.DistutilsPlatformError: Unable to find vcvarsall.bat. distutils#118 (comment)Use
windows-2019instead ofwindows-latestin the workflow descriptionPull Request Checklist
changelog.d/.(See documentation for details)