Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured all methods in setuptools.modified raise a consistant distutils.error.DistutilsError type #4567

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Aug 13, 2024

Summary of changes

The following code should now work as expected in all cases:

from setuptools.modified import newer_pairwise_group
from distutils.error import DistutilsError

try:
    newer_pairwise_group(...)
except DistutilsError:
    pass

I'm not entirely certain my test is correct. Hopefully it should be.

Pull Request Checklist

@Avasam Avasam force-pushed the _distutils.modified.newer_pairwise_group branch 4 times, most recently from 2001168 to 322e6bb Compare August 13, 2024 19:06
@Avasam Avasam force-pushed the _distutils.modified.newer_pairwise_group branch 3 times, most recently from a7a791d to d6db114 Compare August 27, 2024 15:31
@abravalheri abravalheri force-pushed the _distutils.modified.newer_pairwise_group branch from d6db114 to 07b26e7 Compare August 28, 2024 10:45
@Avasam Avasam force-pushed the _distutils.modified.newer_pairwise_group branch 3 times, most recently from 5fe25b5 to a08af03 Compare September 17, 2024 02:36
@Avasam Avasam force-pushed the _distutils.modified.newer_pairwise_group branch from a08af03 to 439ec5a Compare September 18, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant