Omit ruff config from wheel distributions #4652
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much @carsonyl. I believe it to be important to distribute |
abravalheri
requested changes
Sep 26, 2024
MANIFEST.in
Outdated
| @@ -19,3 +19,4 @@ include tox.ini | |||
| include setuptools/tests/config/setupcfg_examples.txt | |||
| include setuptools/config/*.schema.json | |||
| global-exclude *.py[cod] __pycache__ | |||
| global-exclude ruff.toml | |||
There was a problem hiding this comment.
ruff.toml should be included in the sdist as it is important for testing.
carsonyl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/pypa/setuptools/blob/main/setuptools/_vendor/ruff.toml is currently being included in wheels, which is probably unintended since it's only relevant to maintainers.