Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON and JSON Schema classifiers. #142

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Add JSON and JSON Schema classifiers. #142

merged 1 commit into from
Apr 25, 2023

Conversation

Julian
Copy link
Contributor

@Julian Julian commented Apr 24, 2023

Request to add a new Trove classifier.

The name of the classifier(s) you would like to add:

  • Topic :: Internet :: JSON for JSON
  • Topic :: Internet :: JSON :: JSON Schema for JSON Schema underneath it

Why do you want to add this classifier?

No classifier currently collects JSON-adjacent projects despite their ubiquity.
JSON Schema is, thankfully, also quite large at this point, and tooling both within the JSON Schema ecosystem but also in the Open API and Async API ecosystem would likely use the classifier.

I'm not sure if these guidelines are specific to Framework classifiers or whether they'd apply here. I can of course speak for myself on wanting to use these in multiple libraries, but if there's a need to drum up more support obviously let me know! My assumption is certainly that one could find 10 or more for JSON and I'd be surprised if that wasn't the case for the JSON Schema specific one as well.

Where does this belong?

There's Topic :: Text Processing :: Markup :: XML currently for XML, which I think is the closest existing classifier, though it seems equally awkward (as Topic :: Internet) to put JSON in that category. If there was a Topic :: Data Formats or a Topic :: Specifications perhaps one of those would seem decent places, but that's obviously an invasive kind of thing.

@di
Copy link
Member

di commented Apr 25, 2023

I think this makes sense to align more closely with classifiers like Topic :: Text Processing :: Markup :: XML. Maybe something like:

  • Topic :: File Formats :: JSON
  • Topic :: File Formats :: JSON :: JSON Schema

?

@Julian
Copy link
Contributor Author

Julian commented Apr 25, 2023

Cool, that certainly makes sense, as I say I agree! Just wanted to make sure I wasn't being presumptuous about creating new second-level categories without hearing you were up for it.

Do you think we should "move" / "deprecate" / "add" any existing ones under there if added? I.e. Topic :: File Formats :: XML or Topic :: File Formats :: LaTeX?

(And I assume we'd also add Topic :: File Formats itself?)

@di
Copy link
Member

di commented Apr 25, 2023

🤷 I think they're so infrequently used it probably doesn't matter? We can always revisit that later.

@Julian
Copy link
Contributor Author

Julian commented Apr 25, 2023

Works for me. Moved.

Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@di di merged commit f9c794a into pypa:main Apr 25, 2023
@Julian Julian deleted the json branch April 25, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants