Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload: turn attestation error into a warning #1101

Merged

Conversation

woodruffw
Copy link
Member

This tweaks #1099 by turning the error into a warning.

Rationale: @facutuesca pointed out that a hard error here made it much harder to test development deployments of PyPI, i.e. deployed on localhost or a private domain/IP address.

@sigmavirus24 sigmavirus24 merged commit 439dd70 into pypa:main May 6, 2024
22 of 23 checks passed
@woodruffw woodruffw deleted the ww/attestation-warn-not-fail branch May 6, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants