Display error when uploading signed file with no distribution #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmavirus24
requested changes
Oct 20, 2022
sigmavirus24
approved these changes
Oct 22, 2022
|
@sigmavirus24 Is this able to be merged/rerun? Or is someone looking at fixing #936 first? No rush of course, just curious! |
di
approved these changes
Nov 30, 2022
Related to pypa#931. If a user only uploads a signed .asc file without any distribution files, this now throws an error to make it more clear why Twine doesn't do anything.
jmwoliver
force-pushed
the
signed-file-upload-error
branch
from
1d09604
to
b0ac0df
Compare
|
@di Thanks for the approval, I've rebased with your suggestion. It looks like as a first-time contributor, a maintainer needs to run the workflows. Would you mind getting those to run? |
|
This should be ready to merge whenever someone is available to do so! |
|
Thanks for merging, @bhrutledge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #931.
If a user only uploads a signed .asc file without any distribution files, this now throws an error to make it more clear why Twine doesn't do anything.